CodeFoxy-Github/0x0
1
0
Fork 0
forked from mia/0x0
Code Pull requests Activity

README: Clarify why serving file requests from the app is bad

Browse source
This commit is contained in:
Mia Herkt 2022-11-20 16:54:46 +01:00
parent 4ba18146e1
commit b5f0cfdf6f
Signed by untrusted user: mia
GPG key ID: 72E154B8622EC191
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
README.rst
View file

@ -30,8 +30,10 @@ where ``/up`` is whatever you’ve configured as ``FHOST_STORAGE_PATH``.
For all other servers, set ``FHOST_USE_X_ACCEL_REDIRECT`` to ``False`` and
``USE_X_SENDFILE`` to ``True``, assuming your server supports this.
Otherwise, Flask will serve the file with chunked encoding, which sucks and
should be avoided at all costs.
Otherwise, Flask will serve the file with chunked encoding, which has several
downsides, one of them being that range requests will not work. This is a
problem for example when streaming media files: It won’t be possible to seek,
and some ISOBMFF (MP4) files will not play at all.
To make files expire, simply create a cronjob that runs ``cleanup.py`` every
now and then.