From 2ee6f6e9040f039ce69ed94096e5a9a236947cbc Mon Sep 17 00:00:00 2001 From: arch1t3cht Date: Wed, 2 Nov 2022 21:50:01 +0100 Subject: [PATCH] Fix overscan mask being half as thick as it should be The percent values used for the overscan masks follow the BBC's guidelines, as in https://en.wikipedia.org/wiki/Overscan#Overscan_amounts . However, these measure the per-side width as opposed to the total percentage of width/height being cut off. Thus, they should not be divided by two when drawing the mask. --- src/video_display.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/video_display.cpp b/src/video_display.cpp index 1919fc577..100f5f539 100644 --- a/src/video_display.cpp +++ b/src/video_display.cpp @@ -228,7 +228,7 @@ catch (const agi::Exception &err) { void VideoDisplay::DrawOverscanMask(float horizontal_percent, float vertical_percent) const { Vector2D v = Vector2D(viewport_width, viewport_height) / scale_factor; - Vector2D size = Vector2D(horizontal_percent, vertical_percent) / 2 * v; + Vector2D size = Vector2D(horizontal_percent, vertical_percent) * v; // Clockwise from top-left Vector2D corners[] = {