From 32f5e00bf8151dcbe6409e447b53433d84203019 Mon Sep 17 00:00:00 2001 From: Thomas Goyne Date: Tue, 6 May 2014 10:32:19 -0700 Subject: [PATCH] Eliminate a pointless check --- src/aegisublocale.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/aegisublocale.cpp b/src/aegisublocale.cpp index 554da8d8e..156f77ab4 100644 --- a/src/aegisublocale.cpp +++ b/src/aegisublocale.cpp @@ -78,6 +78,10 @@ wxString AegisubLocale::PickLanguage() { } wxArrayString langs = GetTranslations()->GetAvailableTranslations(AEGISUB_CATALOG); + // No translations available, so don't bother asking the user + if (langs.empty() && !active_language) + return "en_US"; + langs.insert(langs.begin(), "en_US"); // Check if user local language is available, if so, make it first @@ -88,13 +92,6 @@ wxString AegisubLocale::PickLanguage() { std::rotate(langs.begin(), it, it + 1); } - // Nothing to pick - if (langs.empty()) return ""; - - // Only one language, so don't bother asking the user - if (langs.size() == 1 && !active_language) - return langs[0]; - // Generate names wxArrayString langNames; for (auto const& lang : langs) {