mantarimay/Aegisub
1
0
Fork 0
forked from mia/Aegisub
Code Pull requests Activity

Fix undefined behavior in DataBlockCache::SetBlockCount()

Browse source 
Left-shifting negative signed numbers is UB (and pointlessly complex
here anyway).
This commit is contained in:
Thomas Goyne 2015-11-25 18:28:25 -08:00
parent 652a250189
commit 4542204b3a
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/block_cache.h
View file

@ -119,9 +119,8 @@ public:
if (data.size() > 0) if (data.size() > 0)
Age(0); Age(0);
macroblock_size = 1 << MacroblockExponent; macroblock_size = 1UL << MacroblockExponent;
macroblock_index_mask = macroblock_size - 1;
macroblock_index_mask = ~(((~0) >> MacroblockExponent) << MacroblockExponent);
data.resize((block_count + macroblock_size - 1) >> MacroblockExponent); data.resize((block_count + macroblock_size - 1) >> MacroblockExponent);
size = 0; size = 0;