mantarimay/Aegisub
1
0
Fork 0
forked from mia/Aegisub
Code Pull requests Activity

Don't declare methods as virtual in a class not intended to be inherited from

Browse source 
Originally committed to SVN as r5190.
This commit is contained in:
Thomas Goyne 2011-01-16 07:14:47 +00:00
parent 84ffb4414a
commit cc5952035e
1 changed files with 20 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
aegisub/src/audio_timing_dialogue.cpp
View file

@ -69,10 +69,10 @@ class AudioMarkerDialogueTiming : public AudioMarker {
public: public:
// AudioMarker interface // AudioMarker interface
virtual int64_t GetPosition() const { return position; } int64_t GetPosition() const { return position; }
virtual wxPen GetStyle() const { return style; } wxPen GetStyle() const { return style; }
virtual FeetStyle GetFeet() const { return feet; } FeetStyle GetFeet() const { return feet; }
virtual bool CanSnap() const { return true; } bool CanSnap() const { return true; }
public: public:
// Specific interface // Specific interface
@ -159,36 +159,36 @@ class AudioTimingControllerDialogue : public AudioTimingController, private Sele
AssFile *ass; AssFile *ass;
// SubtitleSelectionListener interface // SubtitleSelectionListener interface
virtual void OnActiveLineChanged(AssDialogue *new_line); void OnActiveLineChanged(AssDialogue *new_line);
virtual void OnSelectedSetChanged(const Selection &lines_added, const Selection &lines_removed); void OnSelectedSetChanged(const Selection &lines_added, const Selection &lines_removed);
// AssFile events // AssFile events
void OnFileChanged(int type); void OnFileChanged(int type);
public: public:
// AudioMarkerProvider interface // AudioMarkerProvider interface
virtual void GetMarkers(const SampleRange &range, AudioMarkerVector &out_markers) const; void GetMarkers(const SampleRange &range, AudioMarkerVector &out_markers) const;
// AudioTimingController interface // AudioTimingController interface
virtual wxString GetWarningMessage() const; wxString GetWarningMessage() const;
virtual SampleRange GetIdealVisibleSampleRange() const; SampleRange GetIdealVisibleSampleRange() const;
virtual SampleRange GetPrimaryPlaybackRange() const; SampleRange GetPrimaryPlaybackRange() const;
virtual bool HasLabels() const; bool HasLabels() const;
virtual void Next(); void Next();
virtual void Prev(); void Prev();
virtual void Commit(); void Commit();
virtual void Revert(); void Revert();
virtual bool IsNearbyMarker(int64_t sample, int sensitivity) const; bool IsNearbyMarker(int64_t sample, int sensitivity) const;
virtual AudioMarker * OnLeftClick(int64_t sample, int sensitivity); AudioMarker * OnLeftClick(int64_t sample, int sensitivity);
virtual AudioMarker * OnRightClick(int64_t sample, int sensitivity); AudioMarker * OnRightClick(int64_t sample, int sensitivity);
virtual void OnMarkerDrag(AudioMarker *marker, int64_t new_position); void OnMarkerDrag(AudioMarker *marker, int64_t new_position);
public: public:
// Specific interface // Specific interface
/// @brief Constructor /// @brief Constructor
AudioTimingControllerDialogue(AudioController *audio_controller, SelectionController<AssDialogue> *selection_controller, AssFile *ass); AudioTimingControllerDialogue(AudioController *audio_controller, SelectionController<AssDialogue> *selection_controller, AssFile *ass);
virtual ~AudioTimingControllerDialogue(); ~AudioTimingControllerDialogue();
}; };