mantarimay/Aegisub
1
0
Fork 0
forked from mia/Aegisub
Code Pull requests Activity
5359 commits 10 branches 31 tags 48 MiB
Commit graph

1907 commits

Author SHA1 Message Date
Thomas Goyne
439b1272b0 Select current style when the style manager is opened 
Originally committed to SVN as r6421.
 2012-02-01 18:47:10 +00:00
Thomas Goyne
f0933ecb1a When adding new hotkeys, automatically select and start editing the new hotkey 
Originally committed to SVN as r6420.
 2012-02-01 18:47:00 +00:00
Thomas Goyne
499a9b2869 Set thread priorty between Create() and Run() 
Originally committed to SVN as r6419.
 2012-02-01 14:23:52 +00:00
Thomas Goyne
fbe00eabe8 Bump up the size of the log window in the font collector dialog so that it can actually fit font names without wrapping 
Originally committed to SVN as r6418.
 2012-02-01 04:17:39 +00:00
Thomas Goyne
db7924d646 Add a warning in the fontconfig font collector when the chosen font does not have glyphs for some of the characters used in that font 
Originally committed to SVN as r6417.
 2012-02-01 04:17:33 +00:00
Thomas Goyne
98b51e2c23 Clean up DialogStyleManager a bit, eliminating a decent amount of duplicated code and fixing issues with the logic for enabling and disabling the buttons. 
Originally committed to SVN as r6416.
 2012-02-01 00:48:50 +00:00
Thomas Goyne
c6ac746215 Kill DialogStyleManager::OnClose as it just does the default thing 
Originally committed to SVN as r6415.
 2012-02-01 00:48:42 +00:00
Thomas Goyne
b48436c5de Skip unprocessed key events in the style manager 
Originally committed to SVN as r6414.
 2012-02-01 00:48:33 +00:00
Thomas Goyne
3be4693480 Uncrustify AssStyleStorage a bit 
Originally committed to SVN as r6413.
 2012-02-01 00:48:24 +00:00
Thomas Goyne
ac5af24014 Remove pointless #ifdef __APPLE__ around CmdDown() 
The entire point of CmdDown is that it calls ControlDown on non-OS X, so
the ifdefs are completely pointless.

Originally committed to SVN as r6412.
 2012-02-01 00:48:16 +00:00
Thomas Goyne
7bd0691bd7 In PersistLocation get the new location of the dialog directly from the dialog rather than from the event as the data in the event is wrong 
Originally committed to SVN as r6411.
 2012-02-01 00:48:07 +00:00
Thomas Goyne
04cc422391 Close the spell checker after all lines have been checked rather than only once there are no errors remaining. Closes #1442. 
Originally committed to SVN as r6410.
 2012-02-01 00:47:57 +00:00
Thomas Goyne
3af57cdbcd Copy the source line's group in AssDialogue's copy constructor as copying wxStrings is far faster than constructing new ones 
Originally committed to SVN as r6409.
 2012-02-01 00:47:49 +00:00
Thomas Goyne
a7d54f3d69 Make AssEntry::group const as it really should never change 
Originally committed to SVN as r6408.
 2012-02-01 00:47:38 +00:00
Thomas Goyne
8bef1eb874 Destruct AssFiles on a background thread as it's rather slow with large files 
Originally committed to SVN as r6407.
 2012-02-01 00:47:28 +00:00
Thomas Goyne
64553dd633 Handle commands which change types at runtime. Closes #1413. 
Originally committed to SVN as r6406.
 2012-01-31 04:04:02 +00:00
Thomas Goyne
fc96f1bd28 Swallow cancel exceptions thrown from opening audio from the script so that unrelated things aren't canceled 
Originally committed to SVN as r6403.
 2012-01-31 04:03:44 +00:00
Thomas Goyne
c2d3c910c7 Replace some uses of "" with wxString() 
Despite special-casing zero-length input, wxString("") takes over four
times as long as wxString() - and on a 10k line script, this change cuts
AssFile's copy constructor's runtime in half.

Originally committed to SVN as r6401.
 2012-01-31 00:44:43 +00:00
Thomas Goyne
3b0d2ae8e6 Add effect and actor to the things that lines can be sorted by 
Originally committed to SVN as r6400.
 2012-01-31 00:44:34 +00:00
Thomas Goyne
a114238396 Use AssTime::GetASSFormated for the video position display 
Originally committed to SVN as r6399.
 2012-01-31 00:44:26 +00:00
Thomas Goyne
725820efc0 Add support for setting the active line from automation macros 
The macro processing function can now return a second value, which is
the index of the line to make active, which must be one of the lines in
the selection. If it is not, or if the value is not present, then the
active line is left unchanged if it is in the new selection, or set to
the first line of the new selection if it is not.

Closes #1435.

Originally committed to SVN as r6398.
 2012-01-31 00:44:16 +00:00
Thomas Goyne
dad803e956 Set the start and end times of syllables relative to the line's start time rather than time 0 to match 2.1.x's behavior. Closes #1440. 
Originally committed to SVN as r6397.
 2012-01-31 00:44:07 +00:00
Thomas Goyne
4c4ea92d0f Update all spellcheckers after adding a word 
Previously adding a word to the dictionary via the spell checker dialog
would not update the dictionary used by the subs edit box and
vice-versa.

Originally committed to SVN as r6396.
 2012-01-31 00:43:59 +00:00
Thomas Goyne
57fc4145d9 Always use the same language for all spellchecker instances as having different languages in different places is weird 
Originally committed to SVN as r6395.
 2012-01-31 00:43:49 +00:00
Thomas Goyne
e205f9d51b Make the 'Add to dictionary' button in the spellchecker dialog actually do something. Closes #1441. 
Originally committed to SVN as r6394.
 2012-01-31 00:43:40 +00:00
Thomas Goyne
aa49a4eb0f Factor out the options lookups from BaseGrid::GetRowStrings so that they aren't pointlessly checked every row 
Originally committed to SVN as r6393.
 2012-01-31 00:43:32 +00:00
Thomas Goyne
1af19fb42e Make AssTime::GetASSFormated roughly an order of magnitude faster 
Originally committed to SVN as r6392.
 2012-01-31 00:43:23 +00:00
Thomas Goyne
0c972886fb Cache most of the brushes used in grid painting 
Originally committed to SVN as r6391.
 2012-01-31 00:43:15 +00:00
Thomas Goyne
cf1425f9d1 Don't get the strings for hidden columns when painting the grid. Speeds up grid painting by up to 25%. 
Originally committed to SVN as r6390.
 2012-01-31 00:43:06 +00:00
Thomas Goyne
b34d2c547f Use wxAutoBufferedPaintDC rather than manual double-buffering in BaseGrid, as it's simpler and slightly faster 
Originally committed to SVN as r6389.
 2012-01-31 00:42:58 +00:00
Thomas Goyne
e5f1719d8f Use DC clipping in AudioRenderer rather than wxMemoryDC + Blit 
In addition to being far simpler, this is marginally faster as
wxMemoryDC has a decent amount of overhead.

Originally committed to SVN as r6388.
 2012-01-31 00:42:47 +00:00
Thomas Goyne
0bff490b7e Enable/disable the OK button in the TPP dialog when styles are (un)checked 
Originally committed to SVN as r6387.
 2012-01-27 23:35:31 +00:00
Thomas Goyne
049c730813 Fix handling of autosave and autobackup paths that don't end in a slash 
Originally committed to SVN as r6386.
 2012-01-27 21:32:48 +00:00
Thomas Goyne
e258e8c25f Fix crash on empty lines in karaoke mode 
Originally committed to SVN as r6385.
 2012-01-27 20:04:31 +00:00
Thomas Goyne
9e3f280cda Fix bug where opening audio with audio already open would resize the audio display 
Originally committed to SVN as r6384.
 2012-01-27 20:04:22 +00:00
Thomas Goyne
ef4c1b369d Adjust the label for the history box in the shift times dialog to suggest that old shifts can now be loaded 
Originally committed to SVN as r6383.
 2012-01-27 20:04:14 +00:00
Thomas Goyne
642a9df2bf Correct the tooltip for 'Shift to Current Frame' 
Originally committed to SVN as r6382.
 2012-01-27 20:04:05 +00:00
Thomas Goyne
78f1198426 Fix error when adding a word to the dictionary when the user dictionary file doesn't already exist 
Originally committed to SVN as r6381.
 2012-01-27 20:03:55 +00:00
Thomas Goyne
bc9c521cfd Apply the 'Subs Edit Box' hotkey handling to all of the text boxes in the subs edit area rather than just the main text edit. Closes #1431. 
Originally committed to SVN as r6380.
 2012-01-27 19:23:35 +00:00
Thomas Goyne
0dc0135f9a Select the appropriate entry in the zoom dropdown when the zoom is changed externally so that keyboard navigation works. Updates #1433. 
Originally committed to SVN as r6379.
 2012-01-27 19:23:26 +00:00
Thomas Goyne
2d5df24fd6 Update the zoom on Enter in the zoom box. Updates #1433. 
Originally committed to SVN as r6378.
 2012-01-27 19:23:16 +00:00
Thomas Goyne
772c8dee3b Fix accelerator conflict between Redo and Find and Replace 
Originally committed to SVN as r6377.
 2012-01-27 19:23:07 +00:00
Thomas Goyne
16db1eb4dd Add more menu accelerators and fix a conflict between View and Video. Patch by catntabile. Closes #1434. 
Originally committed to SVN as r6376.
 2012-01-27 19:22:57 +00:00
Thomas Goyne
d01c0cf501 Fix crash when drawing a vector clip that does not start with a move. Closes #1430. 
Originally committed to SVN as r6375.
 2012-01-27 19:22:46 +00:00
Thomas Goyne
4746ae8a1d Really unhardcode the Paste Over dialog's height rather than just the width 
Originally committed to SVN as r6374.
 2012-01-26 23:23:41 +00:00
Thomas Goyne
a54983a9bc Fix a few minor issues with the Paste Over dialog 
Remove the pointlessly hardcoded height of the checklist.

Set the parent correctly.

Set the initial focus to the OK button.

Originally committed to SVN as r6373.
 2012-01-26 23:21:19 +00:00
Thomas Goyne
8c246e1cb8 Make shift-scrollwheel scroll the grid a page at a time. Closes #1407. 
Originally committed to SVN as r6372.
 2012-01-26 22:46:09 +00:00
Thomas Goyne
6d550b4a5d Repaint the entire grid on timing changes 
Timing changes can potentially make all of the columns need to be
repainted (due to the collision line color), and the grid currently
isn't smart enough to know when this is actually the case, so just
always repaint the entire thing.

Originally committed to SVN as r6371.
 2012-01-26 22:27:57 +00:00
Thomas Goyne
a1ad0fa585 Use Scintilla's logic for deciding when to coalesce edit box changes 
Scintilla's modification notifications don't expose enough information
to do a very good job of deciding when to group changes with previous
ones, but it does expose when Scintilla thinks undo groups should end,
so just use that.

This should significantly improve the behavior of undo when editing
lines in the edit box.

Originally committed to SVN as r6370.
 2012-01-26 22:13:39 +00:00
Thomas Goyne
d55f1622f1 Fix backwards-compatibilty break in the lua karaoke parser 
Insert an empty syllable at the beginning of the karaoke syllable table
to better mimick 2.1.x's behavior.

Originally committed to SVN as r6369.
 2012-01-26 21:19:25 +00:00
Thomas Goyne
0aec0a9d59 Add an option to skip over commented lines in the spell checker. Closes #1428. 
Originally committed to SVN as r6368.
 2012-01-26 20:51:08 +00:00
Thomas Goyne
92ae4a616e Fix truncation of all float fields in styles 
Originally committed to SVN as r6367.
 2012-01-26 20:17:31 +00:00
Thomas Goyne
99a7eece9c Significantly speed up duplicating multiple lines 
SubtitlesGrid::DuplicateLines iterated over the entire file multiple
times for each line duplicated, making duplicating large numbers of
lines extremely slow.

Originally committed to SVN as r6366.
 2012-01-26 20:08:54 +00:00
Thomas Goyne
15a4eca7ce Fix crash on (auto)save when using CSRI and video is open 
Calling AssFile::Save/Load from multiple threads (even on different
objects) was not safe due to that is uses SubtitleFormat internally,
which was inheriently thread-unsafe. To fix this, change
SubtitleFormat's interface to support immutable implementations, and
make all of the current implementations immutable.

This isn't a perfect solution - making a subtitle format implemented in
lua immutable would be rather difficult - so at some point in the future
SubtitleFormat should probably be changed to a factory which returns new
objects from GetReader/GetWriter.

Originally committed to SVN as r6365.
 2012-01-26 20:08:38 +00:00
Thomas Goyne
d001d66b12 Add support for the scale parameter of vector clips. Closes #1415. 
Originally committed to SVN as r6364.
 2012-01-26 00:29:08 +00:00
Thomas Goyne
214079af58 Load Shift Times settings from history on double-click 
Redesign how shift times history is saved. Previously it stored the
localized strings in the history file, which are not particularly
parsable as the format may differ between locales. Rather than doing
this, store the raw settings in a json file, and generate the history
strings on display. In addition to making it much easier to load old
settings, this makes it so that the history is always displayed using
the current locale, rather than the locale in which the shifting was
done.

Closes #1427.

Originally committed to SVN as r6363.
 2012-01-25 23:09:45 +00:00
Thomas Goyne
2094814077 Save the current row and scroll position in the file and restore it when the file is reopened. Closes #1417. 
Originally committed to SVN as r6362.
 2012-01-25 19:07:36 +00:00
Thomas Goyne
71a4e38c7d Fix over-escaping that resulted in Recombine Lines stripping 't' rather than tabs. Closes #1418. 
Originally committed to SVN as r6361.
 2012-01-25 19:07:27 +00:00
Thomas Goyne
e9dcbf66f3 Fix compilation errors when wxUSE_ON_FATAL_EXCEPTION is not enabled. Updates #1423. 
Originally committed to SVN as r6359.
 2012-01-25 19:07:07 +00:00
Thomas Goyne
d798d69849 Enable the dummy audio provider in release builds. Closes #1425. 
Originally committed to SVN as r6358.
 2012-01-25 19:06:56 +00:00
Thomas Goyne
e7307d249e Fix odd behavior when switching active lines with the Effect or Actor boxes focused 
Originally committed to SVN as r6357.
 2012-01-25 05:49:00 +00:00
Thomas Goyne
f8c27feedb Skip unprocessed key events. Updates #1408. 
Originally committed to SVN as r6356.
 2012-01-25 05:48:53 +00:00
Thomas Goyne
26c3e13340 Fix poor synchronization between mouse and keyboard modifications to the selection 
Combining Shift+Up/Down (or Home/End or Page Up/Page Down) with
shift-clicking had very odd results due to that they used separate
variables to decide where to extend from (and even when only one was
used they were handled incorrectly in some cases).

Closes #1311.

Originally committed to SVN as r6355.
 2012-01-25 04:59:17 +00:00
Thomas Goyne
e6d86a1af4 Don't remove audio files from the recently used files list when loading is cancelled 
Originally committed to SVN as r6354.
 2012-01-25 04:59:11 +00:00
Thomas Goyne
bce29f5a9a Fix bug where "Play current line" would not stop at the end of the line if video was already playing 
Originally committed to SVN as r6353.
 2012-01-25 00:40:21 +00:00
Thomas Goyne
a24f1692be Let macros update their help string from the validate function 
If the second return value from the validate function exists and is a
non-empty string, replace the macro's help text with that string.

Revert r6327, as this is a better solution to the same problem.

Closes #1413.

Originally committed to SVN as r6352.
 2012-01-25 00:21:37 +00:00
Thomas Goyne
1034d16e4b Auto-apply AssFixStylesFilter when sending subtitles to the renderer 
Originally committed to SVN as r6350.
 2012-01-24 01:46:29 +00:00
Thomas Goyne
1c14740d51 Fix check for 'start after' and 'end after' keyframe snapping in the TPP 
Originally committed to SVN as r6349.
 2012-01-24 01:28:26 +00:00
Thomas Goyne
df9f46b49c Actually read the values from the TPP dialog before applying processing 
Originally committed to SVN as r6348.
 2012-01-23 23:53:26 +00:00
Thomas Goyne
3b5bc88285 Write the video's colorspace to the script info section 
Originally committed to SVN as r6347.
 2012-01-23 23:07:35 +00:00
Thomas Goyne
f2aadc7439 Add automatic host API selection to the portaudio player 
Portaudio defaults to using the most stable widely available host API,
rather than the highest performance or quality, and as a result the
default host API on windows (MME) is really quite bad. As such, add
logic to select the best host API for the selected output device.

Closes #1375.

Originally committed to SVN as r6346.
 2012-01-23 21:14:32 +00:00
Thomas Goyne
e6252ae11b Fix adding lead in/out in the timing postprocessor 
The wrong set of lines were being checked for overlaps resulting in
completely broken results.

Originally committed to SVN as r6345.
 2012-01-23 21:01:57 +00:00
Thomas Goyne
0b7d018287 Delete the unused preferences dialog pages 
Originally committed to SVN as r6343.
 2012-01-23 19:02:25 +00:00
Thomas Goyne
8eaf4a6a8e Add most of the remaining "hidden" options to the preferences dialog. Closes #1022. 
Originally committed to SVN as r6342.
 2012-01-23 19:02:15 +00:00
Thomas Goyne
2e37ba8246 Remove redundant OSS device option 
Originally committed to SVN as r6341.
 2012-01-23 19:02:05 +00:00
Thomas Goyne
1f8005d8d1 Add option to hide the main toolbar. Updates #1399. 
Originally committed to SVN as r6340.
 2012-01-22 23:44:24 +00:00
Thomas Goyne
c8099decf3 Fix infinite loop in ALSA player when playing zero-length audio 
Updates #1394.

Originally committed to SVN as r6339.
 2012-01-22 18:18:07 +00:00
Thomas Goyne
e026d2a60a Fix copy/paste error that made the end time and duration boxes not work 
Originally committed to SVN as r6338.
 2012-01-22 18:18:00 +00:00
Thomas Goyne
0287edaa33 Suppress creation of multiple separators in a row in toolbars 
If an entire group of commands in a toolbar is missing (such as with
AssDraw on non-windows), the duplicate separator should go as well to
avoid ugliness. A better solution here would be platform-specific
default toolbars, which should probably be done as part of #495.

Closes #1398.

Originally committed to SVN as r6337.
 2012-01-22 17:15:36 +00:00
Thomas Goyne
7da57b38dc Bind wxEVT_LEAVE_WINDOW in AudioDisplay so the track cursor actually gets removed when the mouse leaves the display 
Originally committed to SVN as r6336.
 2012-01-22 17:15:31 +00:00
Thomas Goyne
c0b599fbae Only play audio on next/prev line in karaoke mode 
Originally committed to SVN as r6335.
 2012-01-22 17:15:25 +00:00
Thomas Goyne
e10055cb59 Don't try to create an OpenGL context until video is loaded 
Creating it during startup triggers a few valgrind errors in vbox's gl
driver that may or may not matter.

Originally committed to SVN as r6334.
 2012-01-22 05:59:43 +00:00
Thomas Goyne
6c879c12f1 Move the visual tool submode buttons to the main visual tool toolbar 
Creating an entire toolbar for one button in the drag mode is a
pointless waste of space and source of ugliness. The secondary toolbar
was more reasonable for the vector clip tool, but it's still a bit
pointless as there's enough space for it on the main toolbar at any
reasonable zoom level.

Closes #1401.

Originally committed to SVN as r6333.
 2012-01-22 05:59:36 +00:00
Thomas Goyne
d273255814 Use wxDataViewCtrl::EditItem rather than StartEditor when using 2.9.4 as StartEditor is deprecated 
Originally committed to SVN as r6332.
 2012-01-22 05:59:31 +00:00
Thomas Goyne
6d4a56d391 Delete most of VideoBox's members 
VideoBox is down to one method so it doesn't actually need to be able to
reference most of the stuff it constructs.

Originally committed to SVN as r6331.
 2012-01-22 05:59:23 +00:00
Thomas Goyne
d1d4d7840b Obey the icon size option in the visual subtoolbars rather than always using 24x24 icons 
Originally committed to SVN as r6330.
 2012-01-20 23:42:33 +00:00
Thomas Goyne
d253620a96 Remove duplicate *.mov from video format filters 
Originally committed to SVN as r6329.
 2012-01-20 22:36:11 +00:00
Thomas Goyne
c83135cb9b Add a few more a/v formats to the filters. Updates #1397. 
Originally committed to SVN as r6328.
 2012-01-20 22:20:08 +00:00
Thomas Goyne
a939732d9c Add auto4lua support for dynamic help strings 
Rather than passing a string as the second argument to
aegisub.register_macro, they can now pass a function which will be
called (with no arguments) to get a help string.

Originally committed to SVN as r6327.
 2012-01-20 21:33:39 +00:00
Thomas Goyne
b0c1ef2d6b Add support for commands with dynamic help strings 
Originally committed to SVN as r6326.
 2012-01-20 21:33:30 +00:00
Thomas Goyne
64c7043123 Add aegisub.cancel(), which immediates ends macro execution without applying any of the changes that have been made 
Originally committed to SVN as r6325.
 2012-01-20 21:33:20 +00:00
Thomas Goyne
632a02bcc9 Disable keyboard scrolling in the preferences dialog as it eats unrelated key events on wxGTK 
Originally committed to SVN as r6324.
 2012-01-20 15:14:47 +00:00
Thomas Goyne
2e2d896ea9 Fix the font pick buttons in the preferences dialog with wxGTK 
wxGTK doesn't generate spin events when the value of a spin control is
set programmatically, so generate the event ourseleves.

Originally committed to SVN as r6323.
 2012-01-20 15:14:41 +00:00
Thomas Goyne
2bc43eb886 Fix use of uninitialized variable when setting margins to an empty string 
Originally committed to SVN as r6322.
 2012-01-20 05:14:56 +00:00
Thomas Goyne
4675dbb29d Factor out the placeholder text behavior from SubsEditBox and make it work better 
Handle switching from placeholder/normal mode when the value is changed
externally (such as from the active line changing) in addition to on
focus/blur, and improve behavior when the user sets the text to the
placeholder text.

Originally committed to SVN as r6321.
 2012-01-20 05:14:50 +00:00
Thomas Goyne
1ce9b0d31b Refactor SubsEditBox a bit to make the constructor less of a monolithic behemoth and eliminate some duplicated code. 
Originally committed to SVN as r6320.
 2012-01-20 05:14:44 +00:00
Thomas Goyne
8e1ffb7898 Fix off-by-one error in logic for when to reannounce karaoke style ranges 
Originally committed to SVN as r6319.
 2012-01-20 01:49:41 +00:00
Thomas Goyne
a249cfcc35 Add an option to disable autosave as setting the interval to zero isn't very obvious 
Originally committed to SVN as r6318.
 2012-01-20 01:04:24 +00:00
Thomas Goyne
6e09fb1abf Reset syntax highlighter state at the end of override blocks correctly 
With incomplete (or possibly incomplete for \r and \fn) tags at the end
of an override block, the text at the beginning of the next override
block was being incorrectly parsed as part of that tag.

Originally committed to SVN as r6317.
 2012-01-19 19:46:09 +00:00
Thomas Goyne
6a091e3ba2 Don't save the file in the 'opened a new file' commit when 'App/Auto/Save on Every Change' is enabled as it's not actually a change 
Originally committed to SVN as r6316.
 2012-01-19 19:46:01 +00:00