mantarimay/Aegisub
1
0
Fork 0
forked from mia/Aegisub
Code Pull requests Activity
Aegisub/aegisub
History
Niels Martin Hansen 70d41d31b2 Remove the SelectionChangeSubscriber mechanism from the grid and implement some basic selection change notification through SelectionController. 
Change SelectionListener interface so it receives the set of lines added and removed from selection, instead of just the complete new selection.
Update VisualTool<> to use SelectionListener to receive selection change notifications.

This change (temporarily, I hope) breaks feature selection in visual drag mode, when changing selection via the grid. This is caused by the grid selection change first clearing the entire selection, which sends a separate notification about selection clear. This causes the last visual feature to be deselected, and then the visual tool base reselects the active line, causing a new notification for selection to be sent. The active line happens to be the newly clicked line, and the selection notification enters during the externalChange guard being set, and is then ignored for feature update purposes. When control returns to the original SelectRow call in the grid, the line to be selected has already been selected and then nothing happens.
The best fix is to avoid two notifications being required to deselect all then reselect one line in the first place, so making the grid selection handling saner is the best fix.

Originally committed to SVN as r4602.
2010-06-26 04:38:02 +00:00
..
automation Add simple automation macros to strip override tags and select overlapping lines. Closes #120. 2010-05-19 00:44:31 +00:00
build Add SelectionController adapted from ADR branch, now templatized on the item data type. Intentionally not making this a merge, the selection controller needs to logically come from trunk into ADR, even if it was added there originally. 2010-06-25 01:44:29 +00:00
desktop Merge r4006 back intro trunk. 2010-01-30 13:43:25 +00:00
docs/doxygen Merge all changes from the libaegisub branch into trunk, the effective range is r4175:4330. All options have been re-done and now use Cajun to support a json-backed format. 2010-05-21 01:13:36 +00:00
libaegisub Include <algorithm> to get std::for_each 2010-06-24 01:51:18 +00:00
libass Update libass to commit 8db4a5. 2010-01-10 21:09:48 +00:00
libffms Merge r4497 to unbreak the build 2010-06-13 06:21:43 +00:00
m4macros Merge r3879. 2009-12-22 05:21:32 +00:00
packages merge r4011,r4012 (Switch from Mac::Finder::DSStore to using AppleScript) 2010-01-21 00:37:04 +00:00
po Merge translations from 2.1.8. 2010-01-26 13:43:02 +00:00
reporter Use uintptr_t which is guaranteed to fit a pointer unlike int. 2010-06-06 02:41:04 +00:00
src Remove the SelectionChangeSubscriber mechanism from the grid and implement some basic selection change notification through SelectionController. 2010-06-26 04:38:02 +00:00
tests Remove rpath hardcoding it's no longer needed. 2010-06-04 13:04:50 +00:00
tinderbox Merge all changes from the libaegisub branch into trunk, the effective range is r4175:4330. All options have been re-done and now use Cajun to support a json-backed format. 2010-05-21 01:13:36 +00:00
tools Fix compilation errors when not using precompiled headers 2010-06-14 19:26:27 +00:00
universalchardet Bring universalchardet up to 41661:ea9bbf0ff87f (2010-03-13). 2010-05-27 02:20:34 +00:00
acinclude.m4 Add two new macros (custom) to search for headers in different directories and libraries with different names. updates #989. 2009-11-17 04:46:46 +00:00
autogen.sh Commit a different patch than the one in #1064.. this sets the default automake required version to 1.10.. the detection for 1.11 is *after* 1.11 because we prefer to use that, though we do prefer to use 1.11 than 1.9 if it's available. Updates #1064 2009-12-13 17:47:19 +00:00
configure.in Add configure check for sys/time.h 2010-06-16 07:49:35 +00:00
INSTALL SVN Transition Step 3/7 2009-03-08 08:30:39 +00:00
LICENCE Update glext.h to a version that isn't four years old 2010-06-07 07:24:18 +00:00
Makefile.am Build universalchardet before libaegisub. 2010-06-12 07:04:12 +00:00
README SVN Transition Step 3/7 2009-03-08 08:30:39 +00:00
wscript Fix the waf build after the libresrc changes, and also tweak the script to properly handle dependency tracking with the generated files. 2010-03-13 17:50:51 +00:00

README 

* To be written.