mia/0x0
3
8
Fork 3
Code Issues 10 Pull requests 2 Projects 1 Wiki Activity

Support user-specified expiration times #72

Manually merged
mia merged 14 commits from :expiration into master 2022-11-29 16:20:08 +01:00
Conversation 11 Commits 14 Files changed 6 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 11cfd07d71 - Show all commits

2
fhost.py
View file

@ -461,7 +461,7 @@ def prune():
File.expiration.is_not(None),
File.expiration < current_time
)
).all()
)
files_removed = 0;
Ember marked this conversation as resolved
mia commented 2022-11-28 11:00:36 +01:00
Review
Copy link

.all() can be omitted here—unless you want to add a fancy progress bar with tqdm?

`.all()` can be omitted here—unless you want to add a fancy progress bar with `tqdm`?
Ember commented 2022-11-28 17:46:47 +01:00
Review
Copy link

Noted! Will do! I think I'll leave out the fancy progress bar because I expect that this script (or at least the part of it that does more than add a new column to an empty database) will run a scarce few times, and there's really only a few existing servers where I expect it to take more than a couple seconds.

Noted! Will do! I think I'll leave out the fancy progress bar because I expect that this script (or at least the part of it that does more than add a new column to an empty database) will run a scarce few times, and there's really only a few existing servers where I expect it to take more than a couple seconds.
Ember commented 2022-11-28 22:48:24 +01:00
Review
Copy link

Oh wait I got mixed up, and thought this comment was on the migration script. Still, I doubt it'll take very long to run, even on larger servers.

Oh wait I got mixed up, and thought this comment was on the migration script. Still, I doubt it'll take very long to run, even on larger servers.
Ember commented 2022-11-28 22:49:47 +01:00
Review
Copy link

11cfd07

11cfd07