mia/Aegisub
1
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity

Kill AegisubApp::OpenURL. It makes no sense for the top level application object to be doing this and it doesn't even save any code.

Browse source 
Originally committed to SVN as r6048.
This commit is contained in:
Thomas Goyne 2011-12-22 21:17:02 +00:00
parent ce62990d91
commit 2ec3ff157b
3 changed files with 4 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
aegisub/src/command/help.cpp
View file

@ -72,7 +72,7 @@ struct help_bugs : public Command {
throw c->parent; throw c->parent;
} }
} }
AegisubApp::OpenURL("http://devel.aegisub.org/"); wxLaunchDefaultBrowser("http://devel.aegisub.org/", wxBROWSER_NEW_WINDOW);
} }
}; };
@ -114,7 +114,7 @@ struct help_forums : public Command {
STR_HELP("Visit Aegisub's forums.") STR_HELP("Visit Aegisub's forums.")
void operator()(agi::Context *) { void operator()(agi::Context *) {
AegisubApp::OpenURL("http://forum.aegisub.org/"); wxLaunchDefaultBrowser("http://forum.aegisub.org/", wxBROWSER_NEW_WINDOW);
} }
}; };
@ -127,7 +127,7 @@ struct help_irc : public Command {
STR_HELP("Visit Aegisub's official IRC channel.") STR_HELP("Visit Aegisub's official IRC channel.")
void operator()(agi::Context *) { void operator()(agi::Context *) {
AegisubApp::OpenURL("irc://irc.rizon.net/aegisub"); wxLaunchDefaultBrowser("irc://irc.rizon.net/aegisub", wxBROWSER_NEW_WINDOW);
} }
}; };
@ -151,7 +151,7 @@ struct help_website : public Command {
STR_HELP("Visit Aegisub's official website.") STR_HELP("Visit Aegisub's official website.")
void operator()(agi::Context *) { void operator()(agi::Context *) {
AegisubApp::OpenURL("http://www.aegisub.org/"); wxLaunchDefaultBrowser("http://www.aegisub.org/", wxBROWSER_NEW_WINDOW);
} }
}; };
} }

10
aegisub/src/main.cpp
View file

@ -546,16 +546,6 @@ int AegisubApp::OnRun() {
return 1; return 1;
} }
/// @brief Open URL
/// @param url
///
void AegisubApp::OpenURL(wxString url) {
wxLaunchDefaultBrowser(url, wxBROWSER_NEW_WINDOW);
}
//////////////// ////////////////
// Apple events // Apple events
#ifdef __WXMAC__ #ifdef __WXMAC__

1
aegisub/src/main.h
View file

@ -121,7 +121,6 @@ public:
/// @return /// @return
/// ///
static AegisubApp* Get() { return (AegisubApp*) wxTheApp; } static AegisubApp* Get() { return (AegisubApp*) wxTheApp; }
static void OpenURL(wxString url);
bool OnInit(); bool OnInit();
int OnExit(); int OnExit();