Thomas Goyne
06e23b9296
Use SetSelectionAndActive whenever both are set at once
...
I'm not sure if this fixes any current actual problems as using slightly
stale data is normally only a problem when lines are being deleted, but
it's easier to fix it across the board than to figure out where it is
and isn't needed, and the speed impact of batching is trivial.
Originally committed to SVN as r6753.
2012-05-05 02:11:09 +00:00
Thomas Goyne
f756aa73c1
Add SelectionController::SetSelectionAndActive, which automatically batches the changes to the selection and active line
...
Originally committed to SVN as r6752.
2012-05-05 02:11:03 +00:00
Thomas Goyne
70abaf75d7
Don't cache the selection in the dialogue timing controller, as getting it isn't very expensive and it was used in a stale state when the active line changed
...
Originally committed to SVN as r6751.
2012-05-05 02:10:57 +00:00
Thomas Goyne
a15024e052
Trigger a modified event on Enter in a time edit so that selecting several lines and hitting Enter to set them all to the active line's time works
...
Originally committed to SVN as r6750.
2012-05-04 02:53:14 +00:00
Thomas Goyne
9269c79763
Only clear the selection due to a click on no visual features if there are actually multiple visual features to select
...
Originally committed to SVN as r6749.
2012-05-04 02:53:09 +00:00
Thomas Goyne
479de87068
Leave the selected range in the audio display unchanged when switching to an untimed line as 2.1.x did
...
Originally committed to SVN as r6748.
2012-05-04 02:53:03 +00:00
Thomas Goyne
1bd24d837c
Allow block selections on the grid with modifier keys held down
...
Originally committed to SVN as r6747.
2012-05-04 02:52:58 +00:00
Thomas Goyne
213ccccf86
Redesign the logic for scrolling the grid on drags
...
Update the grid scroll position on mouse up rather than mouse down,
eliminating the need for the logic that made it impossible to do a drag
selection from the top or bottom rows of the grid, and fix some cases
where the grid would scroll in an undesirable direction.
Originally committed to SVN as r6746.
2012-05-04 02:52:52 +00:00
Thomas Goyne
4d7c6b08e0
Leave the current line selected after splitting at cursor rather than selecting the new line
...
Originally committed to SVN as r6745.
2012-05-03 03:14:11 +00:00
Thomas Goyne
4603a86953
Don't pointless recreate the subs provider when the subs preview is resized
...
Fixes a bug that made it rather awkward to resize the style editor
dialog with libass, as the libass provider briefly creates a modal
dialog whenever it's created, which would interrupt the drag
Originally committed to SVN as r6744.
2012-05-02 22:42:43 +00:00
Thomas Goyne
63d60b9b1e
Save the size of the style editor in addition to the position
...
Originally committed to SVN as r6743.
2012-05-02 22:42:37 +00:00
Thomas Goyne
5a067f56e4
Add command "time/lead/both" which adds both lead in and out
...
Originally committed to SVN as r6742.
2012-05-02 22:42:31 +00:00
Thomas Goyne
8f3b027881
Improve the negative-duration-avoiding behavior of the time edit boxes
...
Save the initial start and end times of lines before adjusting them to
avoid negative line durations, so that if further changes to the edit
boxes make the adjustment unneccesary the original values can be
restored. This Fixes the problem where changing a line visible from
frames 800-900 to 800-901 would actually result in 90-901, due to the
end frame briefly being 90.
Originally committed to SVN as r6741.
2012-05-02 22:42:25 +00:00
Thomas Goyne
252351b7da
Don't stop audio playback when switching lines
...
Originally committed to SVN as r6740.
2012-05-02 22:42:18 +00:00
Thomas Goyne
4be8e3595b
Limit the duration of the lines created with Insert (before) and Insert (after) to the default timing length
...
Originally committed to SVN as r6739.
2012-05-02 00:31:44 +00:00
Thomas Goyne
cb75c42f04
Leave the old audio open when opening new audio fails for any reason
...
Originally committed to SVN as r6738.
2012-05-02 00:31:38 +00:00
Thomas Goyne
b8212512e7
Work around a bug which made style names in the style editor scrolled to the left far sooner than they needed to be
...
Originally committed to SVN as r6737.
2012-05-01 02:50:09 +00:00
Thomas Goyne
2ef7ed98c0
Update the audio scroll position at most once every 50ms when dragging markers
...
Originally committed to SVN as r6736.
2012-05-01 02:50:03 +00:00
Thomas Goyne
1558aa2dad
Increase the height of the audio display scrollbar by 50%
...
Originally committed to SVN as r6735.
2012-05-01 02:49:58 +00:00
Thomas Goyne
4231653146
When joining lines, use the maximum of the lines' end times rather than the last line's end time
...
Originally committed to SVN as r6734.
2012-05-01 02:49:53 +00:00
Thomas Goyne
9e3553c199
Join concatenated lines with a space rather than \N
...
Originally committed to SVN as r6733.
2012-05-01 02:49:48 +00:00
Thomas Goyne
834c2849da
Scroll 1/3 of the audio display per mouse wheel click rather than 120 pixels
...
This is what 2.1.x did (except this actually handles nonstandard wheel
deltas) and is generally far more usable.
Originally committed to SVN as r6732.
2012-05-01 02:49:43 +00:00
Thomas Goyne
1c4bb4a0e2
Split Lead In and Lead Out into separate passes in the TPP
...
This makes it so that if there is a gap between two lines but not enough
space for both the full lead-in and lead-out to be added, adding lead-in
to the second line will be prioritized over adding lead-out to the first
line, which is usually the desired result.
Originally committed to SVN as r6731.
2012-05-01 02:49:38 +00:00
Thomas Goyne
742cbf16aa
Add WebM to the list of supported video formats
...
Originally committed to SVN as r6730.
2012-05-01 02:49:33 +00:00
Thomas Goyne
2deafdd3a7
Fix race condition on shutdown that could result in the program not completely exiting on Windows
...
Originally committed to SVN as r6729.
2012-05-01 02:49:26 +00:00
Thomas Goyne
81d1073a97
Move the auto4 script factories to a local non-heap static to reduce memory leak report noise
...
Originally committed to SVN as r6728.
2012-04-27 19:08:17 +00:00
Thomas Goyne
38e87e2c83
Fix formatting string assertion failure in the search/replace dialog. Closes #1478 .
...
Originally committed to SVN as r6727.
2012-04-27 19:08:09 +00:00
Thomas Goyne
c71734a8a4
Fix the width of the adjacent bias slider in the TPP dialog on wxGTK. Closes #1477 .
...
Originally committed to SVN as r6726.
2012-04-27 19:08:02 +00:00
Thomas Goyne
f3238e2609
Bump required version of wx to 2.9.3
...
Although EVT_CHAR_HOOK was added in 2.9.2, it does not behave in the
required way until 2.9.3.
Originally committed to SVN as r6725.
2012-04-27 19:07:57 +00:00
Thomas Goyne
123f02f0fb
Process hotkeys in wxEVT_CHAR_HOOK rather than wxEVT_KEY_DOWN
...
Char hook events propagate by default, removing the need for the event
filter to make key down events propagate, which was causing some funny
issues.
On Windows, the char hook handler runs before menu accelerators, fixing
a bug where Default context hotkeys would override more specific ones
when they appeared on a menu. Unfortunately, this is not the case on
GTK, so the dumb accelerator-disabling hack is still required.
Originally committed to SVN as r6724.
2012-04-27 19:07:49 +00:00
Thomas Goyne
40b1fbaa1b
Implement audio/play/toggle (default hotkey B)
...
Originally committed to SVN as r6723.
2012-04-27 19:07:42 +00:00
Thomas Goyne
46a27a4e46
Eliminate excess spacing from CellSkip
...
Originally committed to SVN as r6722.
2012-04-27 19:07:36 +00:00
Thomas Goyne
b275399fb1
Add option to draw lines at each second in the audio display
...
Originally committed to SVN as r6721.
2012-04-27 19:07:29 +00:00
Thomas Goyne
8b854283b7
Add audio/commit/default command
...
This command commits the current line, advances to the next line (even
if Auto Next on Commit is disabled), and resets the next line's time to
the default timing as if the next line was zero-timed. Add a default
hotkey of Shift-G, but don't bother with a toolbar button for now as
demand for this turned out to be fairly low.
Closes #946 .
Originally committed to SVN as r6720.
2012-04-27 19:07:21 +00:00
Thomas Goyne
eb26bc51b9
Add commit commands which always stay and always advance regardless of the auto advance setting
...
Originally committed to SVN as r6719.
2012-04-27 19:07:15 +00:00
Thomas Goyne
99a65974e4
Move the Next Line on Commit logic to the commit command so that other commands can do different things
...
Originally committed to SVN as r6718.
2012-04-27 19:07:07 +00:00
Thomas Goyne
79282d7b89
Add the header background color to the preferences dialog
...
Originally committed to SVN as r6717.
2012-04-27 19:06:58 +00:00
Thomas Goyne
e4df8f9654
Reduce the Matroska read-ahead to 1KB
...
We only read subtitles, which are individually very small and generally
have video frames between them, resulting in most of the 65 KB
previously read being wasted. On an arbitrary test file this speeds up
subtitle reading from a cold cache by ~25%, and ~60% from warm.
Originally committed to SVN as r6716.
2012-04-22 15:31:16 +00:00
Thomas Goyne
b13c72e967
Fix a few places where 32-bit fseek/ftell were used in the Matroska reader code
...
Originally committed to SVN as r6715.
2012-04-22 15:31:11 +00:00
Thomas Goyne
35241bdbce
Fix wxString::Format assertion failure when opening subtitles from Matroska
...
Originally committed to SVN as r6714.
2012-04-22 15:31:06 +00:00
Thomas Goyne
95344fdb7c
Always write user dictionaries to ?user/dictionaries
...
The value of Path/Dictionary is not guaranteed to be writable, and on
linux is likely to not be.
Originally committed to SVN as r6713.
2012-04-21 15:13:57 +00:00
Thomas Goyne
fb5f94ca74
Change the spell checker and thesaurus language lists to radio items rather than check items
...
Originally committed to SVN as r6712.
2012-04-21 15:13:51 +00:00
Thomas Goyne
0a64763f2f
Set the audio volume from the slider when audio is opened
...
Originally committed to SVN as r6711.
2012-04-21 15:13:46 +00:00
Thomas Goyne
3c31c1a17a
Store the loaded audio file as a path relative to the subtitles, as is done with video
...
Originally committed to SVN as r6710.
2012-04-21 15:13:40 +00:00
Thomas Goyne
15eb4dc29d
Fix bad option name that caused a fatal error on startup for clean installs
...
Originally committed to SVN as r6709.
2012-04-17 15:03:27 +00:00
Thomas Goyne
3253ccdb90
Move the "Force BT.601" option out of the FFmpegSource category as it's no longer FFMS2-specific, and make it on by default
...
Originally committed to SVN as r6708.
2012-04-16 23:55:21 +00:00
Thomas Goyne
eceac482d0
Add BT.601/BT.709 guessing to the Avisynth video provider along with support for Force BT.601
...
Originally committed to SVN as r6707.
2012-04-16 23:55:15 +00:00
Thomas Goyne
c28a2d33ed
Explicitly enable optimization for the CSRI project to eliminate some link-time warnings about optimizations being disabled
...
Originally committed to SVN as r6706.
2012-04-16 23:55:10 +00:00
Thomas Goyne
c28f262ec4
Use a save file dialog when extracting attachments rather than an open one
...
Originally committed to SVN as r6705.
2012-04-16 23:55:04 +00:00
Thomas Goyne
8a03e3a374
Read and write attachments in binary mode so they don't get mutilated on Windows
...
Originally committed to SVN as r6704.
2012-04-16 23:54:59 +00:00