Incorrect file size check leads to confusing error message on status code 413 page #85

New Issue

Closed

opened 2023-06-04 01:52:22 +02:00 by Ghost · 1 comment

Ghost commented

2023-06-04 01:52:22 +02:00

Error page shows a quite confusing and wrong text like: 512.0 MiB > 512.0 MiB in case the uploaded file's size is equal to the file size limit.

Upload file size check on the backend assures the file size is less than MAX_CONTENT_LENGTH, but on the 413 page text clearly states that content-length is greater than MAX_CONTENT_LENGTH which is not true in case if content-length is equal to MAX_CONTENT_LENGTH. Also this prevents uploading files that are equal to the file size limit, which is wrong in my opinion.

File size check:

if l < app.config["MAX_CONTENT_LENGTH"]:
    def urlfile(**kwargs):
        return type('',(),kwargs)()

    f = urlfile(read=r.raw.read, content_type=r.headers["content-type"], filename="")

    return store_file(f, None, addr, ua, secret)
else:
    abort(413)

Status code 413 template:

Remote file too large ({{ request.headers["content-length"]|filesizeformat(True) }} > {{ config["MAX_CONTENT_LENGTH"]|filesizeformat(True) }}).

I think the best way to resolve this issue would be to change the check to use <= operator instead of <.

Error page shows a quite confusing and wrong text like: `512.0 MiB > 512.0 MiB` in case the uploaded file's size is equal to the file size limit. Upload file size check on the backend assures the file size is less than `MAX_CONTENT_LENGTH`, but on the 413 page text clearly states that `content-length` is greater than `MAX_CONTENT_LENGTH` which is not true in case if `content-length` is equal to `MAX_CONTENT_LENGTH`. Also this prevents uploading files that are equal to the file size limit, which is wrong in my opinion. File size check: ``` if l < app.config["MAX_CONTENT_LENGTH"]: def urlfile(**kwargs): return type('',(),kwargs)() f = urlfile(read=r.raw.read, content_type=r.headers["content-type"], filename="") return store_file(f, None, addr, ua, secret) else: abort(413) ``` Status code 413 template: ``` Remote file too large ({{ request.headers["content-length"]|filesizeformat(True) }} > {{ config["MAX_CONTENT_LENGTH"]|filesizeformat(True) }}). ``` I think the best way to resolve this issue would be to change the check to use `<=` operator instead of `<`.

Ghost changed title from ~~Incorrect file size check leads to confusing error on status code 413 page~~ to Incorrect file size check leads to confusing error message on status code 413 page

2023-06-04 01:53:00 +02:00

Ghost referenced this issue

2023-06-04 02:03:34 +02:00

fix confusing error message on status code 413 page #86