Refactor is_fhost_url to use regex for url matching #54

Closed
7415963987456321 wants to merge 1 commits from 7415963987456321/fhost_url into master
7415963987456321 commented 2021-10-20 01:06:34 +02:00 (Migrated from github.com)

I figured it was a bit unnecessary to have two functions for this so I refactored it into one function.
I thought about introducing fhost_url as a global variable in order to avoid checking for every function call, but I'll await your input on that. This PR introduces re as a dependency, I don't know if you consider that to be excessive, but it certainly simplifies things.

I figured it was a bit unnecessary to have two functions for this so I refactored it into one function. I thought about introducing fhost_url as a global variable in order to avoid checking for every function call, but I'll await your input on that. This PR introduces re as a dependency, I don't know if you consider that to be excessive, but it certainly simplifies things.
mia closed this pull request 2022-08-01 18:23:59 +02:00
mia deleted branch 7415963987456321/fhost_url 2022-08-01 18:24:04 +02:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mia/0x0#54
No description provided.