Commit graph

5662 commits

Author SHA1 Message Date
Thomas Goyne
21f94ae72e Validate the value passed to AssTime's constructor rather than allowing the creation of bad times
Originally committed to SVN as r6060.
2011-12-22 21:18:54 +00:00
Thomas Goyne
515ed54f1d Use a single-line text edit for TimeEdit on wxGTK as the unspecified bugs appear to have been fixed
Originally committed to SVN as r6059.
2011-12-22 21:18:45 +00:00
Thomas Goyne
6a24046b91 Set -fno-var-tracking for command/icon.cpp, as gcc uses an extremely large amount of memory compiling that file otherwise
Originally committed to SVN as r6058.
2011-12-22 21:18:36 +00:00
Thomas Goyne
51d88c675f Actually use FFTW3_CFLAGS and FFTW3_LDFLAGS
Originally committed to SVN as r6057.
2011-12-22 21:18:26 +00:00
Thomas Goyne
3a069b7f60 Clean up TimeEdit
Remove some unused or constant arguments and simplify some overly
convoluted logic.

Check for whether timecodes are open rather than whether video is open
to determine if by-frame mode is enabled.

Operate on a project context rather than using VideoContext::Get().

Use non-event-generating setter methods rather than a boolean ready
variable.

Make all member variables private and add setters rather than relying on
the client code calling Update when appropriate.

Eliminate flickering in overwrite mode.

Originally committed to SVN as r6056.
2011-12-22 21:18:16 +00:00
Thomas Goyne
70d703255b Skip unprocessed key events in the time edit control so that it doesn't eat hotkeys
Originally committed to SVN as r6055.
2011-12-22 21:18:07 +00:00
Thomas Goyne
cd3b9bfa37 Enable propagation of key events so that hotkeys work regardless of what's focused
Originally committed to SVN as r6054.
2011-12-22 21:17:58 +00:00
Thomas Goyne
59273bac4a Reenable the assertion failure handler
Originally committed to SVN as r6053.
2011-12-22 21:17:49 +00:00
Thomas Goyne
28e8f0b640 Use wxGetApp() rather than wxTheApp plus a cast
Originally committed to SVN as r6052.
2011-12-22 21:17:40 +00:00
Thomas Goyne
92949bc965 Remove AegisubApp::Get, as wxGetApp() does the same thing
Originally committed to SVN as r6051.
2011-12-22 21:17:30 +00:00
Thomas Goyne
3e539835b7 Use wxDECLARE_APP rather than the deprecated DECLARE_APP
Originally committed to SVN as r6050.
2011-12-22 21:17:21 +00:00
Thomas Goyne
f1ff18545a Make more of AegisubApp's methods private
Originally committed to SVN as r6049.
2011-12-22 21:17:12 +00:00
Thomas Goyne
2ec3ff157b Kill AegisubApp::OpenURL. It makes no sense for the top level application object to be doing this and it doesn't even save any code.
Originally committed to SVN as r6048.
2011-12-22 21:17:02 +00:00
Thomas Goyne
ce62990d91 Don't wrap the declaration of AegisubApp::HandleEvent in a ifdef check for wxUSE_EXCEPTIONS as we require that wx be built with exception support
Originally committed to SVN as r6047.
2011-12-22 21:16:53 +00:00
Thomas Goyne
a66cc26706 Remove all calls to wxKeyEvent::StopPropagation. Key events don't propagate by default and even if they did, events which are marked as processed don't propagate further.
Originally committed to SVN as r6046.
2011-12-22 21:16:43 +00:00
Thomas Goyne
ed51e7b668 Fix memory leak when deleting or cutting rows
Originally committed to SVN as r6045.
2011-12-22 21:16:34 +00:00
Thomas Goyne
79fa487678 Delete the DVD subtitle format. It didn't work and it's been years since anyone last touched it.
Originally committed to SVN as r6044.
2011-12-22 21:16:23 +00:00
Thomas Goyne
ef32c75609 Also remove empty attachment sections not at the end of the file
Originally committed to SVN as r6043.
2011-12-22 21:16:14 +00:00
Thomas Goyne
921f6c3bcf Remove empty attachment sections from the file while deleting attachments rather than when the dialog is closed to remove a redundant undo point
Originally committed to SVN as r6042.
2011-12-22 21:16:05 +00:00
Thomas Goyne
384d2bc9c2 Disable the Delete and Extract buttons in the attachment dialog after deleting the selected attachments
Originally committed to SVN as r6041.
2011-12-22 21:15:56 +00:00
Thomas Goyne
38e2403001 Factor out duplicated code in DialogAttachments
Originally committed to SVN as r6040.
2011-12-22 21:15:47 +00:00
Thomas Goyne
96aa9e2629 Use libaegisub io code in AssAttachment rather than wx's
Originally committed to SVN as r6039.
2011-12-22 21:15:37 +00:00
Thomas Goyne
00bc0c7ef8 Significantly clean up and simplify AssAttachment
Originally committed to SVN as r6038.
2011-12-22 21:15:28 +00:00
Thomas Goyne
eaf436657e Factor out a bunch of duplicated code in AssStyle::Parse
Originally committed to SVN as r6037.
2011-12-22 21:15:19 +00:00
Thomas Goyne
9eaad5f0b1 Document most of AssStyle and remove some unused code
Originally committed to SVN as r6036.
2011-12-22 21:15:10 +00:00
Thomas Goyne
dbf3eea732 Remove pointless empty destructor from AssStyle
Originally committed to SVN as r6035.
2011-12-22 21:15:01 +00:00
Thomas Goyne
d28c4c4d8b Kill AssEntry::Valid, as there wasn't actually any way to get a fully-constructed entry with it set to false
Originally committed to SVN as r6034.
2011-12-22 21:14:51 +00:00
Thomas Goyne
61767e4453 Disable the "Update video" checkbox in the search/replace dialog when video isn't open
Originally committed to SVN as r6033.
2011-12-22 21:14:42 +00:00
Thomas Goyne
404e0fda4f Delete stuff in DialogSearchReplace
Originally committed to SVN as r6032.
2011-12-22 21:14:32 +00:00
Thomas Goyne
ac9b09b847 Jump to the end of the video rather than the frame before the current one when trying to seek to the next keyframe after the last keyframe
Originally committed to SVN as r6031.
2011-12-22 21:14:24 +00:00
Thomas Goyne
bf7e4d5cc1 Fix bug where seeking to the next keyframe would actually seek to the keyframe after the next keyframe
Originally committed to SVN as r6030.
2011-12-22 21:14:15 +00:00
Thomas Goyne
95fe6a523f Actually use the selection foreground color for selected rows in the grid
Originally committed to SVN as r6029.
2011-12-22 21:14:06 +00:00
Thomas Goyne
6ee6e10117 Fix infinite loop when switching between the \pos and \move icons in the visual subtoolbar
Originally committed to SVN as r6028.
2011-12-22 21:13:57 +00:00
Thomas Goyne
c27ee9fcb8 Disable gcc's unused value warning for tests as a very large number of tests generate it
Originally committed to SVN as r6027.
2011-12-22 21:13:48 +00:00
Thomas Goyne
b29606759a Only include character encodings actually supported by the iconv implementation used in the list returned from GetEncodingsList
Originally committed to SVN as r6026.
2011-12-22 21:13:39 +00:00
Thomas Goyne
ebde064cb4 Set rpath for tests correctly
Originally committed to SVN as r6025.
2011-12-22 21:13:30 +00:00
Thomas Goyne
10255ae201 Overload operator<< for UnknownElement as gcc complains about abiguous calls otherwise
Originally committed to SVN as r6024.
2011-12-22 21:13:22 +00:00
Thomas Goyne
b0c17b9be2 FFTW 3.3 is required, not 3.2
Originally committed to SVN as r6023.
2011-12-22 21:13:13 +00:00
Thomas Goyne
78580c31ba Fix spelling error in configure script
Originally committed to SVN as r6022.
2011-12-22 21:13:04 +00:00
Thomas Goyne
61b1741376 Remove all the json::Reader::Read overloads, as we never actually use them
Originally committed to SVN as r6021.
2011-12-22 21:12:55 +00:00
Thomas Goyne
ba1d1596de Eliminate a pile of duplicated code in elements.cpp
Originally committed to SVN as r6020.
2011-12-22 21:12:46 +00:00
Thomas Goyne
2edc5c41e1 Remove kludges to force options to doubles
Originally committed to SVN as r6019.
2011-12-22 21:12:37 +00:00
Thomas Goyne
07da6f6f1b Split json::Number into json::Double and json::Integer
Trying to decide whether an option should be an int or double after
discarding the differences between "1.0" and "1" simply isn't possible,
and even if an option was initialized correctly, if it was changed to a
round number it could get written as an int and break later.

Also convert cajun to tabs because three spaces to indent is terrible.

Originally committed to SVN as r6018.
2011-12-22 21:12:25 +00:00
Thomas Goyne
daff67b150 Simply log errors and continue when type errors occur while loading the user config file, rather than only loading the portion of the file before the error
Originally committed to SVN as r6017.
2011-12-22 21:12:15 +00:00
Thomas Goyne
d7ae51a5af Remove some unused members of agi::Options
Originally committed to SVN as r6016.
2011-12-22 21:12:06 +00:00
Thomas Goyne
2f73b55b64 Delete agi::Options::DumpAll declaration, as the definition doesn't exist
Originally committed to SVN as r6015.
2011-12-22 21:11:57 +00:00
Thomas Goyne
4c3d191de8 Significantly simplify agi::Options::PutOption
Originally committed to SVN as r6014.
2011-12-22 21:11:46 +00:00
Thomas Goyne
56165305a4 Change the check for duplicate keys when writing the options file to an assertion as it can't actually happen
Originally committed to SVN as r6013.
2011-12-22 21:11:38 +00:00
Thomas Goyne
4823706206 Fix some spelling errors in comments in option.h
Originally committed to SVN as r6012.
2011-12-22 21:11:29 +00:00
Thomas Goyne
a7a159288f Make agi::Options's one protected member private, as agi::Option is not designed to be inherited from
Originally committed to SVN as r6011.
2011-12-22 21:11:21 +00:00