mia/0x0
3
8
Fork 3
Code Issues 11 Pull requests 2 Projects 1 Wiki Activity

PUT: Add initial support #63

Open
Ghost wants to merge 3 commits from (deleted):feat/put/add-support into master
pull from: (deleted):feat/put/add-support
merge into: mia:master
Conversation 2 Commits 3 Files changed 3 +67 -3
Ghost commented 2022-09-26 17:56:20 +02:00
First-time contributor
Copy link

Initial implementation. Not thoroughly tested yet.

Fixes: #62

~~Initial implementation. Not thoroughly tested yet.~~ Fixes: https://git.0x0.st/mia/0x0/issues/62
Ghost added 1 commit 2022-09-26 17:56:21 +02:00
Ghost added 1 commit 2022-09-26 18:13:38 +02:00
Ghost added 1 commit 2022-11-28 07:58:19 +01:00
mia commented 2022-11-29 23:44:42 +01:00
Owner
Copy link

If we’re going to add PUT support, we might as well use the appropriate response codes (so it returns 201 for newly created files and 200 for existing files, each with the Location header field). Those can be the same for POST requests.

There must also be a way to specify any additional parameters using header fields (e.g. X-Expires).

I want to support DELETE as well, which I plan to do with a random key that is attached to the response headers for the initial upload. That functionality should be available for the POST interface as well.

I will implement deletion support separately from this PR.

If we’re going to add PUT support, we might as well use the appropriate response codes (so it returns 201 for newly created files and 200 for existing files, each with the `Location` header field). Those can be the same for POST requests. There must also be a way to specify any additional parameters using header fields (e.g. `X-Expires`). I want to support DELETE as well, which I plan to do with a random key that is attached to the response headers for the initial upload. That functionality should be available for the POST interface as well. I will implement deletion support separately from this PR.
mia reviewed 2022-11-29 23:46:40 +01:00
tests/test_client.py
@ -79,3 +79,64 @@ def test_client(client):
rv = client.get(p)
assert rv.status_code == code
def test_client_put(client):
mia commented 2022-11-29 23:46:40 +01:00
Owner
Copy link

There shouldn’t be so much duplication here.

There shouldn’t be so much duplication here.
mia commented 2022-12-01 03:01:53 +01:00
Owner
Copy link

File deletion is implemented now.

File deletion is implemented now.
This pull request has changes conflicting with the target branch.
  • templates/index.html
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mia/0x0#63
No description provided.
Delete branch "(deleted):feat/put/add-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?